Repository navigation
feature: add endpoint autoscaling to sagemaker.serve and fix managed instance scaling for fine-tuned deployments #6591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
lhnealreilly
wants to merge
6
commits into
aws:master
Choose a base branch
from
lhnealreilly:fix/model-customization-managed-instance-scaling
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
c2eb5d9
fix: honor managed_instance_scaling on model customization deployments
lnealrei 51d2864
feature: add sagemaker.serve.autoscaling and keep falsy shape fields
lnealrei 1006cdc
feature: step scaling, scheduled actions, custom metrics and more tar…
lnealrei 52ef7a5
fix: keep empty nested shapes out of serialized requests
lnealrei 31183f9
fix: page through autoscaling describe calls and clarify a metric wit…
lnealrei 5584393
Merge branch 'master' into fix/model-customization-managed-instance-s…
lhnealreilly File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 Low: This change makes
_serialize_shapeemit any field whose serialized value is a non-None, non-empty-dict, non-empty-list value, including0,Falseand"". That is the intended fix (and is now consistent with_serialize_dict/_serialize_list), but it is a behavior-widening change for all shapes, not just managed instance scaling: fields previously set to an empty string or0and silently dropped will now be sent to the API. Worth confirming no existing callers relied on the old drop-on-falsy behavior (e.g. default""fields on other shapes) — the added regression tests only cover a few shapes.