Repository navigation
feature: resolve the native crash handler library from split apks #404
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 61 additions & 5 deletions
66
packages/react-native/android/src/main/java/backtrace/library/common/AbiHelper.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,70 @@ | ||
| package backtraceio.library.common; | ||
|
|
||
| import android.os.Build; | ||
| import android.os.Process; | ||
|
|
||
| import androidx.annotation.RequiresApi; | ||
|
|
||
| public class AbiHelper { | ||
| @SuppressWarnings("deprecation") | ||
| public static String getCurrentAbi() { | ||
| if (android.os.Build.VERSION.SDK_INT >= android.os.Build.VERSION_CODES.LOLLIPOP) { | ||
| // on newer Android versions, we'll return only the most important Abi version | ||
| return Build.SUPPORTED_ABIS[0]; | ||
| // CPU_ABI follows the bitness of the running process; SUPPORTED_ABIS[0] is only the device preference. | ||
| String processAbi = normalize(Build.CPU_ABI); | ||
| if (processAbi != null) { | ||
| return processAbi; | ||
| } | ||
|
|
||
| String bitnessAbi = firstValidAbi(getProcessBitnessAbis()); | ||
| if (bitnessAbi != null) { | ||
| return bitnessAbi; | ||
| } | ||
|
|
||
| String supportedAbi = firstValidAbi(Build.SUPPORTED_ABIS); | ||
| if (supportedAbi != null) { | ||
| return supportedAbi; | ||
| } | ||
|
|
||
| throw new IllegalStateException("Unable to determine the current process ABI"); | ||
| } | ||
|
|
||
| private static String[] getProcessBitnessAbis() { | ||
| if (Build.VERSION.SDK_INT < Build.VERSION_CODES.M) { | ||
| return null; | ||
| } | ||
| return Api23Impl.getProcessBitnessAbis(); | ||
| } | ||
|
|
||
| @RequiresApi(api = Build.VERSION_CODES.M) | ||
| private static final class Api23Impl { | ||
| private Api23Impl() { | ||
| } | ||
|
|
||
| static String[] getProcessBitnessAbis() { | ||
| return Process.is64Bit() ? Build.SUPPORTED_64_BIT_ABIS : Build.SUPPORTED_32_BIT_ABIS; | ||
| } | ||
| } | ||
|
|
||
| private static String firstValidAbi(String[] abis) { | ||
| if (abis == null) { | ||
| return null; | ||
| } | ||
| for (String abi : abis) { | ||
| String normalizedAbi = normalize(abi); | ||
| if (normalizedAbi != null) { | ||
| return normalizedAbi; | ||
| } | ||
| } | ||
| return null; | ||
| } | ||
|
|
||
| private static String normalize(String abi) { | ||
| if (abi == null) { | ||
| return null; | ||
| } | ||
| String normalizedAbi = abi.trim(); | ||
| if (normalizedAbi.isEmpty() || Build.UNKNOWN.equals(normalizedAbi)) { | ||
| return null; | ||
| } | ||
| // on pre-Lollip versions, we got only one Abi | ||
| return Build.CPU_ABI; | ||
| return normalizedAbi; | ||
| } | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.