Repository navigation
bugfix(android): breadcrumbs logged during a send fail the upload - #405
Merged
Merged
Conversation
# Conflicts: # packages/react-native/src/breadcrumbs/FileBreadcrumbsStorage.ts
KishanPRao
marked this pull request as ready for review
October 5, 2026 16:54
KishanPRao
changed the title
KishanPRao
changed the title
melekr
approved these changes
Oct 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Android report uploads no longer fail when the app logs a breadcrumb right before sending, and those breadcrumbs now arrive with the report.
Changes
BacktraceFileSystemProvider.java: keep line breaks when reading a file.BacktraceFileSystemProviderTest.java: new, cover reading a file and a missing file.FileSnapshotAttachment.ts: new, send the breadcrumb file's current content on android, keep the file path on ios.FileBreadcrumbsStorage.ts: use the snapshot attachment for breadcrumb files, include breadcrumbs not yet written to the file, keep uploads within the breadcrumb limits.BacktraceFileAttachment.ts: let subclasses return file content.FileContent.ts: new, type for in-memory file content.fileSnapshotAttachmentTests.spec.ts: new, cover breadcrumbs written during and right before an upload, file rotation, breadcrumb limits.ref: BT-7453