Repository navigation
Build with Go 1.26.11 - #1027
Merged
Merged
Conversation
Sets toolchain go1.26.11 for GO-2026-6859 (net/http), which govulncheck reports under 1.26.10 and which fails the Security check on main and on every open pull request. The go line stays 1.26.7.
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 1 file
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
Contributor
There was a problem hiding this comment.
🟢 Approved
No active review issues are reported for the Go 1.26.11 toolchain update.
No open issues 🎉
What changed in this PR
Updates the CLI’s preferred Go toolchain to address GO-2026-6859 in net/http, which has been failing the required Security check.
Changes:
- Bumps
toolchainfromgo1.26.10togo1.26.11for CI and release builds. - Keeps the minimum Go version at
1.26.7; Nix compiler selection remains unchanged.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
go.mod |
Updates the preferred toolchain to Go 1.26.11 without changing dependencies or the minimum Go version. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Sets
toolchain go1.26.11ingo.mod. Thegoline stays 1.26.7, and no other file pins 1.26.10.Why
govulncheck reports GO-2026-6859 (
net/http) in the Go 1.26.10 standard library, fixed in 1.26.11. The requiredSecuritycheck has been failing onmainand on every open pull request since the advisory was published. setup-go reads the toolchain line, so every CI and release job builds and scans with 1.26.11 once this lands.Verified
govulncheck -tags dev ./...finds no vulnerabilities under 1.26.11, and reports GO-2026-6859 again when forced back to 1.26.10.bin/cion a clean checkout of this branch.Not verified
flake.lockis not touched, so Nix builds keep the Go their nixpkgs pin gives them.Summary by cubic
Bumps the Go toolchain to 1.26.11 so govulncheck stops reporting GO-2026-6859 (
net/http), which has been failing the Security check onmainand every open PR. Thegoline stays at 1.26.7; only thetoolchaindirective changes.Written for commit 17c99ee. Summary will update on new commits.
This PR appears safe to merge.Summary
Updates
go.modfromtoolchain go1.26.10totoolchain go1.26.11, while keepinggo 1.26.7.Reviews (1) · Last reviewed commit: "Build with Go 1.26.11" · Reviewed by Greptile