Repository navigation
security: harden release artifact validation - #495
Merged
codeforester merged 3 commits intoOct 28, 2026
Merged
Conversation
codeforester
force-pushed
the
security/486-20261028-artifact-content-checks
branch
from
October 27, 2026 18:53
c8541ec to
3660261
Compare
codeforester
commented
Oct 27, 2026
codeforester
commented
Oct 27, 2026
codeforester
commented
Oct 27, 2026
codeforester
commented
Oct 27, 2026
Contributor
Author
|
Implemented the review fixes in commit
|
Contributor
Author
|
Addressed the remaining lint and maintainability feedback in commit
The directory-entry and symlink regression tests remain in place. |
codeforester
deleted the
security/486-20261028-artifact-content-checks
branch
October 28, 2026 15:01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
base_clifiles byte-for-byte with the reviewed source treescripts/in sdistsSecurity rationale
The release validator now fails closed before installation. It checks both wheel and sdist content and does not import or execute the artifact while validating it.
Validation
UV_CACHE_DIR=/private/tmp/base-cli-uv-cache uv run --extra dev pytest -q tests/test_validate_package_artifact.pyUV_CACHE_DIR=/private/tmp/base-cli-uv-cache uv run --extra dev python -m build --wheel --sdistUV_CACHE_DIR=/private/tmp/base-cli-uv-cache uv run --extra dev python scripts/validate_package_artifact.py distgit diff --checkpassRelates to #486.