Repository navigation
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
WORKSPACE compatibility regressions and the outdated integration lockfile need to be fixed.
3 open issues
What changed in this PR
Adds module-wide package metadata to rules_python and uses the PURL builder to encode wheel package URLs correctly.
Changes:
- Declares module identity and Apache-2.0 license metadata.
- Replaces manual wheel PURL formatting with the builder API.
- Upgrades
package_metadataand adds the builder dependency.
| File | Description |
|---|---|
| REPO.bazel | Applies package metadata module-wide. |
| python/private/pypi/patch_and_extract_whl.bzl | Builds wheel PURLs with encoded fields. |
| python/private/pypi/BUILD.bazel | Declares the PURL library dependency. |
| MODULE.bazel | Upgrades package_metadata to 0.0.13. |
| BUILD.bazel | Defines module and license metadata. |
Review effort: Balanced
| ":license", | ||
| ], | ||
| purl = purl.bazel( | ||
| module_name(), |
| name = normalize_name(metadata.name).replace("_", "-") | ||
|
|
||
| qualifiers = {} | ||
| builder = purl.builder().type("pypi").name(name).version(metadata.version) |
| bazel_dep(name = "bazel_features", version = "1.21.0") | ||
| bazel_dep(name = "bazel_skylib", version = "1.8.2") | ||
| bazel_dep(name = "package_metadata", version = "0.0.7") | ||
| bazel_dep(name = "package_metadata", version = "0.0.13") |
darkrift
force-pushed
the
use_purl_builder
branch
2 times, most recently
from
October 17, 2026 12:14
5c2446a to
687c853
Compare
darkrift
force-pushed
the
use_purl_builder
branch
from
October 17, 2026 12:23
687c853 to
b6111d1
Compare
Comment on lines
+3
to
+5
| repo( | ||
| default_package_metadata = [ | ||
| "//:package_metadata", |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This declares the module package metadata and switch to the purl builder which takes care of encoding the various fields of the purl.