Skip to content

agents: document git archive export-subst, precondition, and daemon rules #4277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rickeylev merged 1 commit into from
Oct 17, 2026
Merged

agents: document git archive export-subst, precondition, and daemon rules #4277

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .agents/rules/github_actions_workflows.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,10 @@ globs: ".github/workflows/**"
* **Event Payload Resolution**: For steps that are a single Python script,
loading event details directly from `$GITHUB_EVENT_PATH` is required (strong
suggestion otherwise) rather than passing fields via env vars or CLI flags.
* **Preserve `export-subst` in `git archive`**: Always pass a commit or tag ref
(never a raw `git write-tree` SHA) to `git archive` so `.gitattributes`
`export-subst` placeholders (such as `$Format:...$` in `python/features.bzl`)
expand. Use `--add-file` to include generated files.

## Workflow Python Scripts & Testing
* **Executable Permissions**: Workflow step scripts must have `chmod +x` (mode
Expand Down
3 changes: 3 additions & 0 deletions .agents/rules/python.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,9 @@
## CLI & Arguments
* Use direct attribute access (e.g. `args.foo`) on `argparse.Namespace` with
well-defined shapes. Avoid defensive `getattr()`.
* Assume caller-guaranteed preconditions hold (e.g., input directories exist
and contain files). Do not add silent no-op guards (`if path.is_dir():` or
`if not path.is_file(): continue`) that mask broken invocations.

## Interface & ABC Docstrings
* In abstract base class / interface methods, always document `Args:`,
Expand Down
6 changes: 4 additions & 2 deletions .agents/skills/monitor-ci-results/SKILL.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,12 @@ or when monitoring CI after PR updates:
with `|| ... monitor_remote_ci.py <pr_number>` in a single shell invocation,
as `pgrep -af` will match the parent `bash -c` command string and exit `0`.
2. **Launch Monitoring Script**: If no monitor process is active for
`<pr_number>`, launch the script in the background:
`<pr_number>`, launch the script via `run_command` with `IsDaemon: true` and
`WaitMsBeforeAsync: 500` (do NOT append a trailing `&`, which causes the
shell to exit immediately and kills the background process):
```bash
./.agents/skills/monitor-ci-results/scripts/monitor_remote_ci.py \
<pr_number> "<your_conversation_id>" &
<pr_number> "<your_conversation_id>"
```

### ✨ Autonomous Subagent Orchestration
Expand Down
Loading