Repository navigation
Fix missing constraints in run_loop scheduler queries and attribute queries such as starts_on - #330
Merged
Merged
Conversation
|
coverage: 92.688% (-0.1%) from 92.819% — Cra3z:main into bemanproject:main |
Cra3z
marked this pull request as draft
October 27, 2026 13:56
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Cra3z
marked this pull request as ready for review
October 28, 2026 12:39
…r-sender is dependent-sender
dietmarkuehl
approved these changes
Oct 28, 2026
dietmarkuehl
left a comment
dietmarkuehl
left a comment
Member
There was a problem hiding this comment.
Looks good. Some of these change reminded me that there is probably value in a better way for computing completion signatures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix missing constraints in
run_loopscheduler queries and attribute queries such asstarts_on.