Skip to content

Simplify get_completion_signatures implementation for some sender adaptors - #331

Open
Cra3z wants to merge 2 commits into
bemanproject:mainfrom
Cra3z:main
Open

Cra3z wants to merge 2 commits into
bemanproject:mainfrom
Cra3z:main

Conversation

@Cra3z

@Cra3z Cra3z commented Oct 29, 2026

Copy link
Copy Markdown
Collaborator

For sender adaptors that require both get_completion_signatures and transform_sender member functions (like starts_on and bulk):

  • When an environment is provided (i.e., ex::get_completion_signatures<Sender, Env>()), it actually retrieves the completion signatures of the new sender resulting from transform_sender.
  • The adaptor's own get_completion_signatures member is only invoked when no environment is provided (i.e., ex::get_completion_signatures<Sender>()).
  • In this latter case, the behavior should be equivalent to passing an empty environment as the third argument to transform_sender to get a new sender, and then fetching the completion signatures of that new sender.

@coveralls

coveralls commented Oct 29, 2026 •

Copy link
Copy Markdown

Coverage Status

coverage: 92.688%. remained the same — Cra3z:main into bemanproject:main

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants