Skip to content

Unpack the natives directory from a relative smoke set path - #558

Merged
bernardladenthin merged 1 commit into
mainfrom
ccr-90fc5f6a-vs4s0f
Oct 22, 2026
Merged

bernardladenthin merged 1 commit into
mainfrom
ccr-90fc5f6a-vs4s0f

Conversation

@bernardladenthin

Copy link
Copy Markdown
Owner

Summary

  • Round 3 (natives directory via lib.path) of the linux-x86-64, linux-aarch64 and macOS smoke rows failed in run 39799320257: unzip: cannot find or open smoke/llama-...-cpu-linux-x86-64.jar. smoke_natives_directory (.github/smoke-lib.sh) unzips each jar after a cd into the output directory, but find had returned the jar paths relative to the job's directory (publish.yml passes the set as smoke). The Windows rows unpack in PowerShell and passed.
  • The function now resolves the set directory to an absolute path first and fails with a named error when it does not exist.
  • smoke-lib.sh is repo-local (not in .github/shared-files.sha256), so no sibling repo is affected.

Test plan

  • New .github/buildcheck/tests/test_smokelib.py: a two-jar set (library + Vulkan module) unpacked with a relative and an absolute set path, plus a missing set directory. The relative case was red before the fix with the exact CI error and is green after it.
  • python3 -m unittest discover -s .github/buildcheck/tests -t .github: 148 tests OK
  • check-shared-files.py, check-run-scripts.py, bash -n clean
  • CI is green on this branch (the three smoke rows reach round 3's server start)

Related issues / PRs

Refs run https://github.com/bernardladenthin/java-llama.cpp/actions/runs/39799320257 (introduced by 3a8a260).


Generated by Claude Code

smoke_natives_directory unzipped each jar after a cd into the output
directory, while find had returned the jar paths relative to the job's
directory: publish.yml passes the set as `smoke`. Round 3 of the
linux-x86-64, linux-aarch64 and macOS smoke rows failed with "cannot
unzip smoke/llama-...-cpu-linux-x86-64.jar" (run 39799320257); the
Windows rows unpack in PowerShell and passed.

The function now resolves the set directory to an absolute path first.
test_smokelib.py drives it over a two-jar set with a relative and an
absolute path (the relative case is red without the fix).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VBFFnrhtvXiUeyxjmUc4R2

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01VBFFnrhtvXiUeyxjmUc4R2
@coderabbitai

coderabbitai Bot commented Oct 22, 2026

Copy link
Copy Markdown

Review in Change Stack →

Note

Currently processing new changes in this PR. This may take a few minutes, please wait...

⚙️ Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 082fed21-d61a-4787-bed6-81a28f555db4
📥 Commits

Reviewing files that changed from the base of the PR and between 772998e and 6d28d4c.

📒 Files selected for processing: 2
  • .github/buildcheck/tests/test_smokelib.py
  • .github/smoke-lib.sh
+---------------------------------------------+
| Rabbit in the repo, here to fix that bug 🎶 |
+---------------------------------------------+
  \
   \     /)/)
        ( '')
        /  |
      o(___)
✨ Finishing Touches
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@bernardladenthin
bernardladenthin merged commit fb6b693 into main Oct 22, 2026
9 of 17 checks passed
@bernardladenthin
bernardladenthin deleted the ccr-90fc5f6a-vs4s0f branch October 22, 2026 22:32
@sonarqubecloud

Copy link
Copy Markdown

This branch had an error being deployed

1 failed deployment
startgate — 6d28d4c1 Deployed Oct 22, 2026 by bernardladenthin via Start gate (abort window) #1323
maven-central — 6d28d4c1 Deployed Oct 22, 2026 by bernardladenthin via Verify GPG signing key (no secrets printed) #1323
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants