Repository navigation
Unpack the natives directory from a relative smoke set path - #558
Merged
Merged
Conversation
smoke_natives_directory unzipped each jar after a cd into the output directory, while find had returned the jar paths relative to the job's directory: publish.yml passes the set as `smoke`. Round 3 of the linux-x86-64, linux-aarch64 and macOS smoke rows failed with "cannot unzip smoke/llama-...-cpu-linux-x86-64.jar" (run 39799320257); the Windows rows unpack in PowerShell and passed. The function now resolves the set directory to an absolute path first. test_smokelib.py drives it over a two-jar set with a relative and an absolute path (the relative case is red without the fix). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VBFFnrhtvXiUeyxjmUc4R2 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VBFFnrhtvXiUeyxjmUc4R2
bernardladenthin
had a problem deploying
to
startgate
October 22, 2026 22:31 — with
GitHub Actions
Error
bernardladenthin
had a problem deploying
to
maven-central
October 22, 2026 22:31 — with
GitHub Actions
Failure
bernardladenthin
had a problem deploying
to
maven-central
October 22, 2026 22:31 — with
GitHub Actions
Failure
|
Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configuration
📒 Files selected for processing: 2
✨ Finishing Touches
Comment |
|
This branch had an error being deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
lib.path) of thelinux-x86-64,linux-aarch64and macOS smoke rows failed in run 39799320257:unzip: cannot find or open smoke/llama-...-cpu-linux-x86-64.jar.smoke_natives_directory(.github/smoke-lib.sh) unzips each jar after acdinto the output directory, butfindhad returned the jar paths relative to the job's directory (publish.yml passes the set assmoke). The Windows rows unpack in PowerShell and passed.smoke-lib.shis repo-local (not in.github/shared-files.sha256), so no sibling repo is affected.Test plan
.github/buildcheck/tests/test_smokelib.py: a two-jar set (library + Vulkan module) unpacked with a relative and an absolute set path, plus a missing set directory. The relative case was red before the fix with the exact CI error and is green after it.python3 -m unittest discover -s .github/buildcheck/tests -t .github: 148 tests OKcheck-shared-files.py,check-run-scripts.py,bash -ncleanRelated issues / PRs
Refs run https://github.com/bernardladenthin/java-llama.cpp/actions/runs/39799320257 (introduced by
3a8a260).Generated by Claude Code