Repository navigation
Require a complete cover credit; check output under the build's base path - #104
Merged
Merged
Conversation
…path check-plugin-output.rb took an entry with a blank or misspelt title, credit or url as a credit, and the page shipped an empty link. It also read the site with no base path, so under a Pages base path its link and image checks matched nothing; CI now passes BASE_PATH to it as it does to the build. Printing in dark mode left the page margins near-black: the dark rule's color-scheme is as specific and loads later than the print one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Second round of adversarial review.
script/check-plugin-output.rb: a_data/covers.ymlentry with a blank or misspelttitle,creditorurlpassed, and the page shipped an empty credit link. It now needs all three. Verified on a scratch copy (titel:for language-models.jpg fails 17 posts).script/check-plugin-output.rbread the site with an empty base path while CI builds with the Pages one, so its translation-listing and image-size checks matched nothing under a non-empty base path. It now takesBASE_PATHwhen set, and the workflow passes it. Verified: with| listedremoved from_includes/category-posts.htmland--baseurl /r11, the check was silent before and now reports the listed translations. Today's base path is empty, so this was latent.color-scheme: lightis now!importantin print.No change to
_data/post_conventions.ymland no new lint rule.Checks: all five gates pass on a fresh build.