Repository navigation
Check Related reading and the search index on the built site - #105
Merged
Merged
Conversation
Every gate passed with the related list emptied in related_posts.rb, and with a comma dropped from search.json, which leaves site search finding nothing. check-plugin-output.rb now fails a post the ranking gives related posts but whose page has no Related reading block, and a search index that does not parse or lacks a post. RelatedPosts.meta builds the ranking input for both the hook and the check.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third round of adversarial review: two gates that passed on a broken site.
docs[i].data["related"] = []in_plugins/related_posts.rb, every post lost its block (36 → 0) and all five gates passed.script/check-plugin-output.rbnow ranks each post withRelatedPosts.rankand fails when the ranking finds related posts but the page has noclass="related-posts"block.RelatedPosts.metabuilds the ranking input, so the hook and the check share it."url"dropped fromsearch.json, the built index did not parse (site search finds nothing) and all gates passed. The check now parses it and requires one entry per post with a url and text.Both verified on scratch copies: each mutation now fails the check, and the unmodified build passes.
No change to
_data/post_conventions.ymland no new lint rule.Checks: all five gates pass on a fresh build.