Repository navigation
Fail an empty alt in htmlproofer; aria-current=location on a post's section - #106
Merged
Merged
Conversation
…ection `` renders alt="", which htmlproofer ignores by default: a screen reader skips the figure and the lightbox loses its caption, with every gate green. CI, README and CLAUDE.md now pass --no-ignore-empty-alt; no current page has an empty alt. On a post the section's nav link is where the reader is, not the page itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fourth round of adversarial review.
--no-ignore-empty-altin CI (and in the README/CLAUDE.md gate commands). An image written asrendersalt="", which htmlproofer ignores by default, so a figure a screen reader skips, and whose lightbox has no caption, shipped with all gates green (verified on a scratch copy). No current page has an empty alt, so the flag passes today.js/main.js: on a post, its section's nav link getsaria-current="location"rather than"page"; the exact page keeps"page".No change to
_data/post_conventions.ymland no new lint rule.Checks: all five gates pass on a fresh build, htmlproofer with the new flag.