Repository navigation
Fail the build when a published URL is no longer built - #107
Merged
Merged
Conversation
A post's URL comes from its date and categories, and legacy_urls.rb's stub follows the current values, so an edit to either sent both indexed URLs to a 404 with every gate green. script/published-urls.txt lists every URL posts have been published under; check-plugin-output.rb fails when one is no longer built as a page or redirect stub, and --record adds new ones. The agentic-patterns post's two hand-written lightbox links were in their own gallery, so the arrows skipped the post's other figures.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fifth round of adversarial review.
date:andcategories. Changing either (scholar-lens correcting a paper date, or a post moved to a new topic) moved the URL, andlegacy_urls.rbbuilds the old/paper%20reviews/…stub from the current values, so it moved too. Both indexed URLs 404'd with every gate green (verified: GraphRAGdate:2024-04-24 → 04-25 on a scratch copy).script/published-urls.txtlists the 65 URLs posts are published under today (36 posts, 28 legacy stubs, one explicitredirect_from).script/check-plugin-output.rb(run byvalidate-site.sh) fails when a listed URL is no longer built as a page or a redirect stub; the scratch copy now fails on both URLs.--recordadds the built posts' URLs and stubs, to run after a post merges. Unlisted posts are not checked, so a scholar-lens PR adding a post still passes.agentic-patternsgallery, so the arrows skipped the post's other figures; they now sharepost-images.scholar-lens: no change needed. Optionally, have it note in its PR that the new URL should be recorded.
No change to
_data/post_conventions.ymland no new lint rule.Checks: all five gates pass on a fresh build.