Repository navigation
Keep post heroes one height; analytics only on the deployed build - #108
Merged
Merged
Conversation
- Reserve two title lines in the post hero, so a two-line title no longer makes its cover taller than its neighbours'; reset for print. - Load Google Analytics only when JEKYLL_ENV=production. - Lint: title and subtitle may not contain a tag (the layouts print them unescaped). - search.js: guard on the status element it writes to. - h4/h6: weight 700, the one loaded (600 already rendered as 700). - README: https link for Centrarium.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
_sass/_layout.scss: the post hero title reserves two lines (min-height: 2lh, centred), so a one- and a two-line title give the same hero height (539px at 1440px for 28 of 30 paper posts; only Gemini 2.5's three-line title is taller). Reset in print. Browsers withoutlhkeep the old behaviour._includes/head.html: Google Analytics only whenjekyll.environment == 'production'(CI sets it); local serves no longer count as traffic.js/search.js:!statusElin the early-return guard._sass/base/_typography.scss: h4/h6 weight 600 -> 700; only 400/700 are loaded, so rendering is unchanged.New lint rule (
script/lint-posts.rb)titleandsubtitlemay not contain<followed by a letter or/, since the layouts print them unescaped.title: "Reasoning with <think> Tokens",subtitle: "<s> 토큰"title: "Mistral 7B < 13B","A <= B","<3"No
post_conventions.ymlchange.Verification
All five gates pass (179 tests). Hero heights measured in Chrome at 360-1440px with no horizontal overflow; print min-height verified as 0.