Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 12 additions & 1 deletion src/cli.rs
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,17 @@ fn is_global_switch_flag(arg: &str) -> bool {
}

pub fn bootstrap_args<I, S>(args: I) -> Result<BootstrapArgs>
where
I: IntoIterator<Item = S>,
S: Into<String>,
{
bootstrap_args_with_default_base_url(args, None)
}

pub fn bootstrap_args_with_default_base_url<I, S>(
args: I,
default_base_url: Option<&str>,
) -> Result<BootstrapArgs>
where
I: IntoIterator<Item = S>,
S: Into<String>,
Expand Down Expand Up @@ -146,7 +157,7 @@ where
Ok(BootstrapArgs {
base_url: resolve_base_url(
env_base_url.as_deref(),
values.cli_base_url.as_deref(),
values.cli_base_url.as_deref().or(default_base_url),
read_optional_env(IS_BLOX_ENV_VAR)?.as_deref(),
read_optional_env(BLOX_ENVIRONMENT_ENV_VAR)?.as_deref(),
),
Expand Down
33 changes: 23 additions & 10 deletions src/kgoose.rs
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,8 @@ pub struct KgooseConfig {
pub goosemcp_playpen: Option<String>,
pub timeout_secs: f64,
pub session_credential: Option<String>,
/// Roxy authenticates the configured Blox tools origin.
pub proxy_auth: bool,
}

impl KgooseConfig {
Expand Down Expand Up @@ -163,7 +165,11 @@ fn build_http_client(config: &KgooseConfig) -> Result<Client> {
let mut headers = HeaderMap::new();
headers.insert(CONTENT_TYPE, HeaderValue::from_static("application/json"));
headers.insert(ACCEPT, HeaderValue::from_static("application/json"));
if let Some(session_credential) = config.session_credential.as_deref() {
if let Some(session_credential) = config
.session_credential
.as_deref()
.filter(|_| !config.proxy_auth)
{
headers.insert(
SESSION_CREDENTIAL_HEADER,
HeaderValue::from_str(session_credential)
Expand All @@ -190,16 +196,18 @@ fn build_http_client(config: &KgooseConfig) -> Result<Client> {
);
}

match env::var(STS_ACCESS_TOKEN_ENV_VAR) {
Ok(access_token) => {
headers.insert(
HeaderName::from_static("x-forwarded-identity-token"),
HeaderValue::from_str(&access_token)
.context("build x-forwarded-identity-token header")?,
);
if !config.proxy_auth {
match env::var(STS_ACCESS_TOKEN_ENV_VAR) {
Ok(access_token) => {
headers.insert(
HeaderName::from_static("x-forwarded-identity-token"),
HeaderValue::from_str(&access_token)
.context("build x-forwarded-identity-token header")?,
);
}
Err(std::env::VarError::NotPresent) => {}
Err(err) => anyhow::bail!("failed to read {STS_ACCESS_TOKEN_ENV_VAR}: {err}"),
}
Err(env::VarError::NotPresent) => {}
Err(err) => anyhow::bail!("failed to read {STS_ACCESS_TOKEN_ENV_VAR}: {err}"),
}

debug_log(format!(
Expand All @@ -212,6 +220,11 @@ fn build_http_client(config: &KgooseConfig) -> Result<Client> {
));

ClientBuilder::new()
.redirect(if config.proxy_auth {
reqwest::redirect::Policy::none()
} else {
reqwest::redirect::Policy::default()
})
.default_headers(headers)
.timeout(config.timeout())
.build()
Expand Down
52 changes: 47 additions & 5 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -15,10 +15,11 @@ use anyhow::{Context, Result};
use clap::error::ErrorKind;
use clap::{ArgMatches, Command};
use cli::{
bool_false_id, bool_true_id, bootstrap_args, build_tools_command, parameter_id,
ToolCommandConfig, APPKIT_COMMAND_ABOUT, APPKIT_COMMAND_NAME, BL_TOOLS_BIN_NAME,
EXTENSION_DESCRIBE_COMMAND_ABOUT, EXTENSION_DESCRIBE_COMMAND_NAME, ROOT_BIN_NAME,
ROOT_COMMAND_NAME, ROOT_SUMMARY, TOOLS_COMMAND_NAME,
bool_false_id, bool_true_id, bootstrap_args, bootstrap_args_with_default_base_url,
build_tools_command, parameter_id, ToolCommandConfig, APPKIT_COMMAND_ABOUT,
APPKIT_COMMAND_NAME, BL_TOOLS_BIN_NAME, EXTENSION_DESCRIBE_COMMAND_ABOUT,
EXTENSION_DESCRIBE_COMMAND_NAME, ROOT_BIN_NAME, ROOT_COMMAND_NAME, ROOT_SUMMARY,
TOOLS_COMMAND_NAME,
};
use runtime::{
load_extension, load_extensions, LoadedExtension, ParameterKind, RuntimeTool, ScalarKind,
Expand All @@ -40,6 +41,7 @@ use crate::proto::squareup::cash::kgoose::api::v3::user_content;

const BL_COMMAND_NAME: &str = "bl";
const BL_SUMMARY: &str = "BuilderLab command line tools";
const BL_TOOLS_BASE_URL_ENV_VAR: &str = "BL_TOOLS_BASE_URL";

#[derive(Debug, Clone, Copy, PartialEq, Eq)]
struct ToolsCliConfig {
Expand Down Expand Up @@ -203,7 +205,16 @@ fn run_tools_cli(argv0: &str, raw_args: &[String], config: ToolsCliConfig) -> Re
return appkit::run(raw_args);
}

let bootstrap = bootstrap_args(raw_args.iter().cloned())?;
let proxy_base_url = if config.builderlab_mode {
blox_tools_base_url()?
} else {
None
};
let bootstrap = if let Some(base_url) = proxy_base_url.as_deref() {
bootstrap_args_with_default_base_url(raw_args.iter().cloned(), Some(base_url))?
} else {
bootstrap_args(raw_args.iter().cloned())?
};

let mut kgoose_config = KgooseConfig {
base_url: bootstrap.base_url.clone(),
Expand All @@ -212,6 +223,7 @@ fn run_tools_cli(argv0: &str, raw_args: &[String], config: ToolsCliConfig) -> Re
goosemcp_playpen: bootstrap.goosemcp_playpen.clone(),
timeout_secs: bootstrap.timeout_secs,
session_credential: None,
proxy_auth: false,
};

let client = HttpKgooseClient;
Expand Down Expand Up @@ -346,6 +358,11 @@ fn apply_builderlab_mode_if_needed(config: &mut KgooseConfig, builderlab_mode: b
if !builderlab_mode {
return Ok(());
}
if tools_proxy_auth_for_url(&config.base_url) {
config.proxy_auth = true;
config.session_credential = None;
return Ok(());
}
let bl_home = read_optional_env(BL_HOME_ENV_VAR)?
.map(std::path::PathBuf::from)
.unwrap_or_else(default_bl_home);
Expand All @@ -364,6 +381,30 @@ fn apply_builderlab_mode_if_needed(config: &mut KgooseConfig, builderlab_mode: b
Ok(())
}

fn blox_tools_base_url() -> Result<Option<String>> {
if std::env::var("IS_BLOX").as_deref() != Ok("true")
|| !std::env::var("BLOX_WORKSTATION_ID").is_ok_and(|id| !id.is_empty())
{
return Ok(None);
}
read_optional_env(BL_TOOLS_BASE_URL_ENV_VAR)
}

fn tools_proxy_auth_for_url(base_url: &str) -> bool {
let Some(configured) = blox_tools_base_url().ok().flatten() else {
return false;
};
let (Ok(configured), Ok(requested)) = (url::Url::parse(&configured), url::Url::parse(base_url))
else {
return false;
};
[&configured, &requested].iter().all(|url| {
matches!(url.scheme(), "http" | "https")
&& url.username().is_empty()
&& url.password().is_none()
}) && configured.origin() == requested.origin()
}

fn bl_org_required_error() -> anyhow::Error {
bl::skills_api::failure(
bl::skills_api::exit_codes::AUTH_REQUIRED,
Expand Down Expand Up @@ -971,6 +1012,7 @@ mod tests {
goosemcp_playpen: None,
timeout_secs: 600.0,
session_credential: None,
proxy_auth: false,
}
}

Expand Down
1 change: 1 addition & 0 deletions src/runtime.rs
Original file line number Diff line number Diff line change
Expand Up @@ -647,6 +647,7 @@ mod tests {
goosemcp_playpen: None,
timeout_secs: 600.0,
session_credential: None,
proxy_auth: false,
}
}

Expand Down
Loading
Loading