Repository navigation
Preserve Apps quota recovery without altering successful JSON - #21
Closed
nathan-thillairajah wants to merge 1 commit into
Closed
nathan-thillairajah wants to merge 1 commit into
nathan-thillairajah wants to merge 1 commit into
Conversation
Adapted from Nandi Wong’s quota client contribution in #8. Keep recovery sanitization off successful responses, retain current validation diagnostics, and describe pending quota cleanup accurately. Signed-off-by: Nathan Thillairajah <nthillairajah@squareup.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Compose refuses a new deployment at the owner's site limit,
bl appsdrops the usage, allowance and structured recovery fields. Preserve those fields alongside the existing HTTP status, trace ID and manifest validation guidance so callers can inspect capacity and choose an explicit retry.Continues Nandi Wong's work in #8. Recovery sanitization applies only to errors: successful debug logs and deletion metadata remain intact. The quota guidance also reflects held failed-deploy reservations and
quota_cleanup_pending, which must not be treated as released capacity.The original sanitizer reproduced three process regressions, including
delete_outcome_unknownafter a successful response. These pass with the fix, as dojust checkandjust package-smoke. Process fixtures verify a realistic capped deploy retains its quota fields and trace without retrying the mutation; a read-only Public staging owned-list check also passed.Customers receive this through a rebuilt CLI or Blox image after merge.