Repository navigation
Preserve subnormal inverse-beta roots in Fisher F quantiles - #1667
Open
hector2394 wants to merge 1 commit into
Open
hector2394 wants to merge 1 commit into
hector2394 wants to merge 1 commit into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1666.
For two beta shape parameters below one, the initial power-series estimate can give a subnormal root that the iteration excludes from its search range. That caused a finite Fisher F upper-tail quantile to throw and a quantile beyond the range of
doubleto return a finite value.Return the estimate when the series correction is below type precision. The tests cover the finite result and overflow with promotion disabled.
On Windows with MSVC, both regressions fail on develop and pass with the patch. The Fisher F suite and the double-precision inverse-beta suite pass.