Repository navigation
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the
Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. WalkthroughDevelopment builds now use webpack’s automatic public path. Test pages load assets from ChangesDevelopment Asset Paths
Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Possibly related PRs
Suggested reviewers: Merge Risk:
|
ab2bbb8 to
fcddc16
Compare
fcddc16 to
12e7bde
Compare
| filename: `[name]${isReactBundle ? '' : '.no.react'}.js`, | ||
| path: outputDir ? path.resolve(outputDir) : path.resolve('dist', version, language), | ||
| publicPath: `/${version}/${language}/`, | ||
| publicPath: isDevBuild ? `/dist/${version}/${language}/` : `/${version}/${language}/`, |
There was a problem hiding this comment.
Could we use 'auto' here? https://webpack.js.org/guides/public-path/#automatic-publicpath
| publicPath: isDevBuild ? `/dist/${version}/${language}/` : `/${version}/${language}/`, | |
| publicPath: isDevBuild ? `'auto' : `/${version}/${language}/`, |
There was a problem hiding this comment.
oh i didn't know that! yes!
| @@ -0,0 +1,7 @@ | |||
| ```sh | |||
There was a problem hiding this comment.
Could you put a bit more context here, maybe just a title saying "How to run the HTML demos"
There was a problem hiding this comment.
yes yes yes that'd probably be good
Overview
The HTML demos load again through a static server rooted at the repo. start:dev used to serve the bundles from memory at /dev/en-US/. The tags and the dev publicPath now point at dist/dev, which is where the development webpack build writes. A local static server then answers both the HTML page and the script.
What
removes the webpack-dev-server URL.
Why
How
Detail, verification, and deferred work
Before, with yarn start:dev:
After:
Checks on this branch:
Summary by CodeRabbit
distoutput paths and standardized HTML doctype formatting.