Repository navigation
fix(provider): keep screenshots inline with transport recovery - #177
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores screenshot delivery to the exact
v0.1.21-telemetry.1provider implementation, removing the screenshot upload adapters and their upload-specific tests. Transport recovery source is byte-for-byte unchanged fromv0.1.21-transport-recovery.1.The previous transport release included all 15 commits between telemetry.1 and screenshot-files.4. Cloud #6394 therefore undid the behavior rollback in #6370.
Red-green proof: the unchanged new regression fails on current main with one upload instead of zero, then passes after restoring inline delivery. Across three real SDK requests it asserts zero uploads/capability calls/deletes, inline image data, no file IDs, and preserved image detail. All seven transport recovery regressions also pass: 8 passed, 0 failed, 59 assertions.
Full provider source comparison to telemetry.1 is empty except the separately retained transport error classification. No documentation, AGENTS, workflow, AWS, or deployment changes in this PR. Staging will require a separate Cloud version/checksum pin and explicit approval.
Summary by cubic
Restores inline screenshot delivery by removing the screenshot upload adapter (
image-files.ts) and its tests, returning to thev0.1.21-telemetry.1provider behavior while keeping transport recovery unchanged fromv0.1.21-transport-recovery.1.The prior transport release bundled all 15 commits between those two tags, which re-introduced the file-upload path that Cloud #6394 was meant to keep rolled back. Provider tests now assert zero uploads, capability calls, and deletes across real SDK requests, with inline image data and no file IDs, and the transport recovery regressions all still pass.
Written for commit 757645b. Summary will update on new commits.
Live staging acceptance passed
The official serve release
0.1.21-transport-recovery.2was pinned by Cloud #6414 with its checksum corrected in #6417, then deployed through https://github.com/browser-use/cloud/actions/runs/37720485491 . The actual binary version and SHA256 were verified in live run072ccdb5-e54d-470a-bbb8-7e519704b647: two screenshots, eight inline image references across seven requests, zero file references, zero Datadog upload events, and independently verified cleanup.tested-in-stagingapplied. No production deployment.