Skip to content

fix(provider): keep screenshots inline with transport recovery - #177

Merged
sarath-menon merged 2 commits into
mainfrom
codex/inline-transport-recovery
Oct 8, 2026
Merged

sarath-menon merged 2 commits into
mainfrom
codex/inline-transport-recovery

Conversation

@sarath-menon

@sarath-menon sarath-menon commented Oct 8, 2026 •

Copy link
Copy Markdown
Collaborator

Restores screenshot delivery to the exact v0.1.21-telemetry.1 provider implementation, removing the screenshot upload adapters and their upload-specific tests. Transport recovery source is byte-for-byte unchanged from v0.1.21-transport-recovery.1.

The previous transport release included all 15 commits between telemetry.1 and screenshot-files.4. Cloud #6394 therefore undid the behavior rollback in #6370.

Red-green proof: the unchanged new regression fails on current main with one upload instead of zero, then passes after restoring inline delivery. Across three real SDK requests it asserts zero uploads/capability calls/deletes, inline image data, no file IDs, and preserved image detail. All seven transport recovery regressions also pass: 8 passed, 0 failed, 59 assertions.

Full provider source comparison to telemetry.1 is empty except the separately retained transport error classification. No documentation, AGENTS, workflow, AWS, or deployment changes in this PR. Staging will require a separate Cloud version/checksum pin and explicit approval.


Summary by cubic

Restores inline screenshot delivery by removing the screenshot upload adapter (image-files.ts) and its tests, returning to the v0.1.21-telemetry.1 provider behavior while keeping transport recovery unchanged from v0.1.21-transport-recovery.1.

The prior transport release bundled all 15 commits between those two tags, which re-introduced the file-upload path that Cloud #6394 was meant to keep rolled back. Provider tests now assert zero uploads, capability calls, and deletes across real SDK requests, with inline image data and no file IDs, and the transport recovery regressions all still pass.

Written for commit 757645b. Summary will update on new commits.

View guided diff Turn on auto-fix

Live staging acceptance passed

The official serve release 0.1.21-transport-recovery.2 was pinned by Cloud #6414 with its checksum corrected in #6417, then deployed through https://github.com/browser-use/cloud/actions/runs/37720485491 . The actual binary version and SHA256 were verified in live run 072ccdb5-e54d-470a-bbb8-7e519704b647: two screenshots, eight inline image references across seven requests, zero file references, zero Datadog upload events, and independently verified cleanup. tested-in-staging applied. No production deployment.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 6 files

View guided diff | Turn on auto-fix | Re-trigger cubic

@sarath-menon
sarath-menon merged commit b200643 into main Oct 8, 2026
3 checks passed
@sarath-menon sarath-menon added tested Verification completed tested-in-staging Verified in shared staging with recorded evidence labels Oct 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tested Verification completed tested-in-staging Verified in shared staging with recorded evidence

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant