Repository navigation
chore(deps): update getrandom to 0.4 (LAB-11170) - #31
Merged
Merged
Conversation
getrandom 0.3 removed getrandom::getrandom; getrandom::fill is its replacement and draws from the same OS source.
Code Review Completed! 🔥The code review was successfully completed based on your current configurations. Kody Guide: Usage and ConfigurationInteracting with Kody
Providing Context (Files & MCPs)Add these hints in your PR description (or a comment) to unlock deeper checks:
Current Kody ConfigurationReview OptionsThe following review options are enabled or disabled:
Kody Code Review — 1 suggested fix. 🛠️ Open Agent Prompt |
Contributor
Author
|
@kody start-review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #13, which does not compile: getrandom 0.3 removed
getrandom::getrandom.Change
create_file_keyfills the 32-byte file-key secret withgetrandom::fill, the 0.3+ replacement. It reads the same OS source as before (getrandom(2)on Linux,getentropyon macOS), and an error still stops ck with "cannot generate a file key".getrandom 0.2 stays in
Cargo.lockas a transitive dependency of other crates; ck's own call is on 0.4.Checks run locally
cargo fmt --all -- --check,cargo clippy --locked --all-targets -- -D warningscargo test --locked: all suites pass, including theruntests that createfile.keycargo deny check: advisories, bans, licenses, sources okcargo +1.85 check --locked --all-targets: rust-version unchangedNo user-facing change, so no docs change and
chore(deps).