Repository navigation
feat(limrun): capture session traffic into a live HAR and report tunnel failures #4043
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
d23f0f7
feat(limrun): capture session traffic into a live HAR with --provider…
thymikee 8b483e0
feat(cli): print delivered provider artifacts when a session closes
thymikee 9be3c78
feat(limrun): report network capture tunnel failures in artifacts and…
thymikee ebf0430
docs(limrun): note that the first request after allocation can skip t…
thymikee 9e20c67
fix(limrun): make a capture that cannot start visible and harden the …
thymikee 7de97ba
docs(limrun): a whole session can occasionally skip the capture
thymikee 31cf8cd
fix(limrun): bound the HAR capture and address review
thymikee 44b0e2d
fix(limrun): refuse a capture whose HAR cannot be written, and cap th…
thymikee e812372
fix(limrun): retry an unavailable capture, tighten an existing captur…
thymikee a597bf4
fix(limrun): refuse a relative HAR path before touching any directory
thymikee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
packages/daemon/src/sessions/handlers/session-doctor-options.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import assert from 'node:assert/strict'; | ||
| import { test } from 'vitest'; | ||
| import type { DaemonRequest } from '../../core/daemon-request.ts'; | ||
| import { remoteConnectionChecks } from './session-doctor-options.ts'; | ||
|
|
||
| function doctorRequest(flags: Record<string, unknown>): DaemonRequest { | ||
| return { | ||
| token: 't', | ||
| session: 'default', | ||
| command: 'doctor', | ||
| positionals: [], | ||
| flags, | ||
| } as DaemonRequest; | ||
| } | ||
|
|
||
| test('an enabled opt-in provider flag counts as configured provider scope', () => { | ||
| const [check] = remoteConnectionChecks(doctorRequest({ providerNetworkLogs: true }), { | ||
| required: true, | ||
| }); | ||
| assert.equal(check?.status, 'pass'); | ||
| assert.deepEqual(check?.evidence, { providerNetworkLogs: '<configured>' }); | ||
| }); | ||
|
|
||
| test('a disabled opt-in provider flag is not provider scope', () => { | ||
| const [check] = remoteConnectionChecks(doctorRequest({ providerNetworkLogs: false }), { | ||
| required: true, | ||
| }); | ||
| assert.equal(check?.status, 'fail'); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.