Repository navigation
fix(ios-mirror): release a held gesture when a panel's frame queue overflows - #65
Merged
Merged
Conversation
…erflows A panel whose video queue overflowed got a new generation but kept the shared iPhone pointer, so the touch stayed down and other panels were blocked as busy. The hub now queues a release on overflow, and a touch that lands after its panel was invalidated still records the pointer so the queued release lifts it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A panel that falls behind while touching a physical iPhone now releases its held touch when its video queue overflows. Other panels can then send input.
The hub queues the release on the existing input queue without blocking video. A touch that finishes after subscriber invalidation still records its pointer, so the queued release can lift it. Other subscribers keep their generation and gestures.
Regression tests cover overflow during a held or in-flight touch and preserve a healthy panel's gesture. The mirror hub, RPC, and Android startup diagnostics suites pass all 23 tests.
Review also found the shared CI privacy test could mistake timing digits for a forwarded port number. It now checks every startup message against the strict schema, with a fixed clock that reproduces the numeric collision. Unknown fields and raw content still fail validation.
Telemetry coverage is preserved: overflow release failures use the existing error capture, and drop counts retain their existing measurement. No production telemetry changed.