Repository navigation
Fall back to Unix Makefiles when Ninja is missing - #108
Conversation
|
|
Does the fact that Chromium is dropping Ninja in favour of Siso have any impact on this? |
Using Ninja by default is just to get the fastest builds possible and CMake doesn't support Siso: This suggested change is just a simple way to degrade gracefully, in case the Ninja is not installed, to not force library authors into using Ninja - if they absolutely doesn't want to install it. |
90dd405 to
8dac805
Compare
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
aba1cde to
3189125
Compare
Fixes #95.
Android builds no longer require Ninja:
cmake-rnfalls back to Unix Makefiles when it isn't installed, and logs a note.CMAKE_MAKE_PROGRAM=ninjais removed, since it breaks Makefiles and CMake finds Ninja onPATHby itself.Reimplemented on current
main, as the original branch targeted the since-renamedreact-native-node-api-cmake. Theout/libweak-node-api.solink failure that kept this in draft no longer reproduces, asweak-node-apino longer sets that output directory.Fallback builds run serially, as
cmake --buildisn't passed--parallel.Test plan
weak-node-apiAndroid build with Ninja hidden fromPATH(all 4 ABIs, Unix Makefiles)Ninja)cmake-rntests, Prettier and ESLintAndroid 🤖)🤖 Generated with Claude Code