Repository navigation
feat(website): add Framefields hero animation for the landing page - #803
Conversation
🦋 Changeset detectedLatest commit: 2e8b76a The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
|
| "render": "tsx src/render.ts video", | ||
| "render:small": "tsx src/render.ts video low", | ||
| "frames": "tsx src/render.ts frames 130 300 500 620 800 1010", | ||
| "typecheck": "tsc -p ." |
There was a problem hiding this comment.
CI skips the animation package
The new typecheck command is not run by CI. Existing checks install only the root package, and later changes under website/** do not trigger the build job. Future animation changes can pass CI even when the package no longer compiles.
As a non-blocking follow-up, add a separate job that installs this package with its lockfile and runs pnpm run typecheck when these files change. This catches broken imports and API changes without requiring a GPU.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Description
This PR adds
website/hero-animation/, Framefields source for the landing herowhich includes :- what nostream is, event flow, features, deploy, NIP count from rootpackage.json, Biome/Docker/changeset tweaks only.Related issue
closes :- #804
How Has This Been Tested?
Test:
cd website/hero-animation && pnpm install && pnpm run setup && pnpm run typecheckScreenshots (if appropriate):
nostream-hero-low.mp4