Repository navigation
fix: recover recorded reasoning effort from Codex thread settings - #54
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
reasoning_effortfrom Codexthread_settings_appliedevents whenturn_context.effortis absent.Verification
npm run checkwith Node 24.19.0: 313 tests passed.git diff --check: passed.Data limit
The screenshot's
Conversation cba6dc20has no effort in its two call records, turn context, applied settings, or local Codex thread state. This change leaves its effort unknown rather than inventing a value. It improves cases where the applied settings event does record the effort.