Repository navigation
ENT-14731: Added tests for cf-reactor - #6430
Merged
Merged
Conversation
Signed-off-by: Victor Moene <victor.moene@northern.tech>
Signed-off-by: Victor Moene <victor.moene@northern.tech>
The check was removed by accident in 9c10ad3. Now it is reverted back to how it was Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
cf-reactor.MoreTests
branch
2 times, most recently
from
October 21, 2026 13:53
0a9ecc2 to
f9acb68
Compare
larsewi
reviewed
Oct 26, 2026
victormlg
force-pushed
the
cf-reactor.MoreTests
branch
from
October 26, 2026 13:54
f9acb68 to
8423363
Compare
larsewi
approved these changes
Oct 26, 2026
Contributor
Author
|
@cf-bottom jenkins, please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14877/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14877/ |
craigcomstock
left a comment
craigcomstock
left a comment
Contributor
There was a problem hiding this comment.
Got this far in commit f6c7ea4
craigcomstock
requested review from
craigcomstock
and removed request for
craigcomstock
October 26, 2026 21:02
victormlg
force-pushed
the
cf-reactor.MoreTests
branch
from
October 27, 2026 09:52
be0b783 to
44cc789
Compare
These tests cover the reactor bundles and the events promise type. Signed-off-by: Victor Moene <victor.moene@northern.tech>
Added a folder to cover all event types with test. Starting with file_deleted. Signed-off-by: Victor Moene <victor.moene@northern.tech>
cf-reactor should parse edit_line bundles so it can use them in the "then" bundles run on reaction to events Signed-off-by: Victor Moene <victor.moene@northern.tech>
The promises of edit_line and edit_xml bundles always used CF_EDIT_IFELAPSED (1 minute) as their ifelapsed, ignoring the default ifelapsed. cf-reactor sets the default to 0 for the bundles it runs on events, so a file edited by an event was not edited again by another event less than a minute later. Edit promises now use the lower of the two (EDIT_IFELAPSED). Signed-off-by: Victor Moene <victor.moene@northern.tech>
… event Signed-off-by: Victor Moene <victor.moene@northern.tech>
If an event promise is guarded by some class, on reaction to an event, the promise is re-expanded however the class is not defined anymore. Now, the expanded promise is saved into the watcher events. Signed-off-by: Victor Moene <victor.moene@northern.tech>
victormlg
force-pushed
the
cf-reactor.MoreTests
branch
from
October 27, 2026 10:00
44cc789 to
d998880
Compare
Since it doesn't actually create users, it doesn't need to be unsafe Signed-off-by: Victor Moene <victor.moene@northern.tech>
larsewi
approved these changes
Oct 27, 2026
Contributor
|
Feel free to continue the review @craigcomstock and we'll make follow-ups. Merging this now to unblock other work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.