Repository navigation
Defaulted ERRORPASS_TESTS in testall - #6442
Merged
Merged
Conversation
ERRORPASS_TESTS was only set when --tests= was passed, causing "[: too many arguments" for every test otherwise. Also listed the errorlog and errorpass test types in the run summary. Changelog: None Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
larsewi
marked this pull request as ready for review
October 26, 2026 13:50
olehermanse
approved these changes
Oct 26, 2026
olehermanse
added
cherry-pick?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ERRORPASS_TESTS(added in 453630a) was only set when--tests=was passed. Without it, the unquoted test attestall:349expanded to[ = 0 -a common = errorpass ], printing[: too many argumentsfor every test (see https://ci.cfengine.com/job/win-acceptance/326/console). It now defaults to1like the other test types.Also added
ERRORLOG_TESTSandERRORPASS_TESTSto the enabled/disabled summary printed at the start of a run.🤖 Generated with Claude Code