Skip to content

fix(cli): hide the policy violation strategy when it is advisory #3761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
migmartri wants to merge 1 commit into from
Closed

fix(cli): hide the policy violation strategy when it is advisory #3761

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 3 additions & 5 deletions app/cli/cmd/attestation_status.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,13 +124,11 @@ func attestationStatusTableOutput(status *action.AttestationStatusResult, w io.W
gt.AppendRow(table.Row{"Timestamp Authority", status.TimestampAuthority})
}

var blockingColor text.Color
var blockingText = action.PolicyViolationBlockingStrategyAdvisory
// Only show the strategy when it is enforced. Showing "ADVISORY" is misleading
// when individual policies are configured as gates.
if status.MustBlockOnPolicyViolations {
blockingColor = text.FgHiYellow
blockingText = action.PolicyViolationBlockingStrategyEnforced
gt.AppendRow(table.Row{"Policy violation strategy", text.FgHiYellow.Sprint(action.PolicyViolationBlockingStrategyEnforced)})
}
gt.AppendRow(table.Row{"Policy violation strategy", blockingColor.Sprint(blockingText)})

evs := status.PolicyEvaluations[chainloop.AttPolicyEvaluation]
if len(evs) > 0 {
Expand Down
6 changes: 5 additions & 1 deletion app/cli/cmd/workflow_workflow_run_describe.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,7 +164,11 @@ func workflowRunDescribeTableOutput(run *action.WorkflowRunItemFull) error {
}
}

gt.AppendRow(table.Row{"Policies violation strategy", att.PolicyEvaluationStatus.Strategy})
// Only show the strategy when it is enforced. Showing "ADVISORY" is misleading
// when individual policies are configured as gates.
if att.PolicyEvaluationStatus.Strategy == action.PolicyViolationBlockingStrategyEnforced {
gt.AppendRow(table.Row{"Policies violation strategy", att.PolicyEvaluationStatus.Strategy})
}
if att.PolicyEvaluationStatus.Blocked {
gt.AppendRow(table.Row{"Run Blocked", att.PolicyEvaluationStatus.Blocked})
}
Expand Down