Repository navigation
feat(stack-encrypt,eql-bindings): open every JSON target through the owned traits #1664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
coderdan
wants to merge
1
commit into
feat/stack-encrypt-eql-types-as-fields
from
feat/stack-encrypt-json-targets-owned-traits
+1,026
−60
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| --- | ||
| '@cipherstash/eql': minor | ||
| --- | ||
|
|
||
| `eql-bindings`, the Rust crate released with this package: the parts of a `JsonSearch` document now decrypt through the owned API. | ||
|
|
||
| - `JsonTreeExtracted`, the entry `->` returns, implements `DecryptSource<JsonPlaintext>`. | ||
| - `JsonTreeSubtree`, the rows of a subtree read, implements `DecryptSource` for `JsonPlaintext`, `Option<JsonPlaintext>` and `Vec<JsonPlaintext>`. | ||
| - The decrypted value is a `JsonPlaintext`, which is wiped when it is dropped. | ||
| - The context is required. Pass the document's column. For a document that is a field of a record with scopes or bindings, pass the column, then those scopes and bindings. | ||
|
|
||
| The stored format, the SQL bundle, and the TypeScript types do not change. | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Document the
decryptioncall break in the eql-bindings changeset.The changeset is the release note for the
eql-bindingscrate. Callers that import bothDecryptIntoandDecryptSourcemust name the trait indecryptioncalls, because both traits define that method. The stack-encrypt changelog records this, but theeql-bindingsnote does not, and no upgrade guide covers it. Add the break to this changeset.Suggested changeset addition
- The context is required. Pass the document's column. For a document that is a field of a record with scopes or bindings, pass the column, then those scopes and bindings. +- Callers that import both `DecryptInto` and `DecryptSource` must name the trait in `decryption` calls, for example `DecryptSource::decryption(document, context)`. An unqualified call is ambiguous and fails to compile. The stored format, the SQL bundle, and the TypeScript types do not change.Source: Coding guidelines