Repository navigation
fix(mosaic): coordinate pending identifier actions - #10481
austincalvelage wants to merge 13 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: ee99bc2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review.
 |
| Check name | Status | Explanation | Resolution |
|---|---|---|---|
| Docstring Coverage |  |
Docstring coverage is 15.38% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documenta… | Write docstrings for the functions missing them to satisfy the coverage threshold. |
-
Check name Status Explanation Title check The title "fix(mosaic): coordinate pending identifier actions" matches the main change. The changeset adds a shared pending-action lock per section (email, phone, web3 wallets). It keeps menus open wi… Description check The description states that setting an email, phone, or wallet as primary keeps the menu open with a pending indicator. It also describes the shared section lock, the guarded removal confirmation, and… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title "fix(mosaic): coordinate pending identifier actions" matches the main change. The changeset adds a shared pending-action lock per section (email, phone, web3 wallets). It keeps menus open with pending indicators during primary changes and guards removal. The title is concise, follows a conventional-commit style, and names the affected package.
Full details: Description check
-
Explanation
The description states that setting an email, phone, or wallet as primary keeps the menu open with a pending indicator. It also describes the shared section lock, the guarded removal confirmation, and the per-row pending state. These points match the raw summary's changes to the user-profile sections, the
usePendingActionhook, and the controllers. The description is directly related to the changeset.
-
Full details: Docstring Coverage
-
Explanation
Docstring coverage is 15.38% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 13 functions across 25 files. (3 skipped: 3 unsupported.)
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.
Comment @coderabbitai help to get the list of available commands.
austincalvelage
changed the title
1e8a5d2 to
85e56c4
Compare
austincalvelage
changed the title
85e56c4 to
625bbc3
Compare
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-biometrics
@clerk/expo-google-signin
@clerk/expo-native-components
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
…tifier-action-lock
usePendingAction gains guard(), which runs a confirmation's confirm under the section lock, replacing runExternal and the wrapper each section copied. Section controllers put verify and primary pending flags on the rows they return, so views no longer compare pending keys. Confirmation drops the disabled prop, which no reachable state could set.
Set as primary stayed pending while the session verification dialog was open, so its menu stayed open with a spinner behind the dialog. The pending status now ends when the dialog appears, as ActionMenu expects.
Email, phone and web3 wallet rows list the primary first when the section loads, then keep their positions when a new primary is set, so only the Primary badge moves. The new primary leads on the next load.
Description
Setting an email address, phone number, or wallet as primary now keeps its menu open with a pending indicator, then updates the Primary badge without moving rows. If the change needs session verification, the menu closes when the verification dialog opens. A shared section lock prevents primary changes and removal from running at the same time. Failed removals keep their confirmation dialog open with the error.
Each section controller owns the lock.
usePendingAction.guardruns the removal confirmation under it, and the rows the controller returns carry their own pending state, so views no longer compare pending keys.Fixes CORE-4051.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change