Skip to content

fix(localizations): use future tense for nl-NL and nl-BE - #10507

Merged
wobsoriano merged 3 commits into
mainfrom
rob/nl-future-tense-verification
Oct 28, 2026
Merged

wobsoriano merged 3 commits into
mainfrom
rob/nl-future-tense-verification

Conversation

@wobsoriano

Copy link
Copy Markdown
Member

Description

Takeover of #9523 by @jorisvdz, who found and fixed this. Their commits are kept as-is.

Checklist

  • pnpm test runs as expected.
  • pnpm build runs as expected.
  • (If applicable) JSDoc comments have been added or updated for any package exports
  • (If applicable) Documentation has been updated

Type of change

  • 🐛 Bug fix
  • 🌟 New feature
  • 🔨 Breaking change
  • 📖 Refactoring / dependency upgrade / documentation
  • other:

@vercel

vercel Bot commented Oct 28, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
clerk-js-sandbox Ready Ready Preview Oct 28, 2026 11:33pm UTC
swingset Ready Ready Preview Oct 28, 2026 11:33pm UTC

Request Review

@changeset-bot

changeset-bot Bot commented Oct 28, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: fbd7293

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@clerk/localizations Patch
@clerk/ui Patch
@clerk/chrome-extension Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 9fca3bb and fbd7293.

Files selected for processing: 3
  • .changeset/open-teeth-hunt.md
  • packages/localizations/src/nl-BE.ts
  • packages/localizations/src/nl-NL.ts
Linked repositories identified

CodeRabbit considers these linked repositories for cross-repo context during reviews:

Included review availability: This review used your included allowance. 7 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 10 reviews per hour.

Walkthrough

The email and phone verification hints in nl-NL and nl-BE now say that a verification message will be sent. A patch changeset records the localization update.

Priority: Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Possibly related PRs

  • clerk/javascript#9523: Updates the same email and phone verification hints in nl-NL and nl-BE to future tense and adds a changeset.
Merge Risk: Minimal · up to fbd72

No actionable merge-blocking risk was identified.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly identifies the change: future-tense wording in the nl-NL and nl-BE localizations.
Description check Passed The description identifies the pull request as a bug fix and explains that it takes over the issue, so it is related to the changeset.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 2 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Oct 28, 2026

Copy link
Copy Markdown

Open in StackBlitz

@clerk/astro

npm i https://pkg.pr.new/@clerk/astro@10507

@clerk/backend

npm i https://pkg.pr.new/@clerk/backend@10507

@clerk/chrome-extension

npm i https://pkg.pr.new/@clerk/chrome-extension@10507

@clerk/clerk-js

npm i https://pkg.pr.new/@clerk/clerk-js@10507

@clerk/electron

npm i https://pkg.pr.new/@clerk/electron@10507

@clerk/electron-passkeys

npm i https://pkg.pr.new/@clerk/electron-passkeys@10507

@clerk/eslint-plugin

npm i https://pkg.pr.new/@clerk/eslint-plugin@10507

@clerk/expo

npm i https://pkg.pr.new/@clerk/expo@10507

@clerk/expo-biometrics

npm i https://pkg.pr.new/@clerk/expo-biometrics@10507

@clerk/expo-google-signin

npm i https://pkg.pr.new/@clerk/expo-google-signin@10507

@clerk/expo-native-components

npm i https://pkg.pr.new/@clerk/expo-native-components@10507

@clerk/expo-passkeys

npm i https://pkg.pr.new/@clerk/expo-passkeys@10507

@clerk/express

npm i https://pkg.pr.new/@clerk/express@10507

@clerk/fastify

npm i https://pkg.pr.new/@clerk/fastify@10507

@clerk/hono

npm i https://pkg.pr.new/@clerk/hono@10507

@clerk/localizations

npm i https://pkg.pr.new/@clerk/localizations@10507

@clerk/mosaic

npm i https://pkg.pr.new/@clerk/mosaic@10507

@clerk/nextjs

npm i https://pkg.pr.new/@clerk/nextjs@10507

@clerk/nuxt

npm i https://pkg.pr.new/@clerk/nuxt@10507

@clerk/react

npm i https://pkg.pr.new/@clerk/react@10507

@clerk/react-router

npm i https://pkg.pr.new/@clerk/react-router@10507

@clerk/shared

npm i https://pkg.pr.new/@clerk/shared@10507

@clerk/tanstack-react-start

npm i https://pkg.pr.new/@clerk/tanstack-react-start@10507

@clerk/testing

npm i https://pkg.pr.new/@clerk/testing@10507

@clerk/ui

npm i https://pkg.pr.new/@clerk/ui@10507

@clerk/upgrade

npm i https://pkg.pr.new/@clerk/upgrade@10507

@clerk/vue

npm i https://pkg.pr.new/@clerk/vue@10507

commit: fbd7293

@github-actions

Copy link
Copy Markdown
Contributor

API Changes Report

Generated by Break Check on 2026-10-28T23:35:42.169Z

Summary

Metric Count
Packages analyzed 20
Packages with changes 0
🔴 Breaking changes 0
🟡 Non-breaking changes 0
🟢 Additions 0

No API Changes Detected

All packages have stable APIs with no detected changes.


Report generated by Break Check

Last ran on fbd7293.

@wobsoriano
wobsoriano merged commit 83c06bb into main Oct 28, 2026
58 checks passed
@wobsoriano
wobsoriano deleted the rob/nl-future-tense-verification branch October 28, 2026 23:43

This branch was successfully deployed

2 active deployments
Preview – swingset — fbd7293b Deployed Oct 28, 2026 by vercel[bot]
Preview – clerk-js-sandbox — fbd7293b Deployed Oct 28, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants