Repository navigation
fix: bump typescript version to 5.0.0 and uuid to 11.1.1 - #645
Closed
phodgkinson-signiant wants to merge 2 commits into
Closed
phodgkinson-signiant wants to merge 2 commits into
phodgkinson-signiant wants to merge 2 commits into
Conversation
* added package.json for kafka example Signed-off-by: Femi <alayesanmifemi@gmail.com> * feat: added client and admin for kafka topics Signed-off-by: Femi <alayesanmifemi@gmail.com> * feat: added producer for kafka sample Signed-off-by: Femi <alayesanmifemi@gmail.com> * feat: added consumer for kafka sample Signed-off-by: Femi <alayesanmifemi@gmail.com> * chore: remove dotenv import in sample file for kafka client Signed-off-by: Femi <alayesanmifemi@gmail.com> * chore: added readme with usage and kafka installation guide for easy usage Signed-off-by: Femi <alayesanmifemi@gmail.com> --------- Signed-off-by: Femi <alayesanmifemi@gmail.com> Signed-off-by: Peter Hodgkinson <phodgkinson@signiant.com>
package.json - uuid: ^8.3.2 → ^11.1.1 - @types/uuid: removed (uuid v11 ships its own types) - typescript: ^4.3.5 → ^5.0.0 (required by uuid v11's bundled types) - @types/node: ^14.14.10 → ^20.0.0 (TS 5 + Node ≥20 engines alignment) - typedoc: ^0.22.11 → ^0.25.0 (peer dep on TS 5) - @typescript-eslint/parser + eslint-plugin: ^4.29.0 → ^6.0.0 (TS 5 API compat) src/event/validation.ts — replaced the @ts-ignore'd reduce with a properly typed reduce<string>. Same behavior, no suppression needed. src/parsers.ts — added a small as string cast on the parseJSON return to keep the existing public API shape. Verified: npm install, npm run lint, npm run build, npm test (222 passing) Signed-off-by: Peter Hodgkinson <phodgkinson@signiant.com>
phodgkinson-signiant
force-pushed
the
bump-uuid
branch
from
May 14, 2026 15:59
9a277fd to
e73f144
Compare
Contributor
|
This pull request is stale because it has been open 30 days with no activity. |
Contributor
|
I have separated package version bumps from functional changes. Once that change is in, let's reduce the scope of this change. |
duglin
pushed a commit
that referenced
this pull request
Oct 25, 2026
) Bring the test and build tooling that the open Snyk PRs targeted up to date in one change against current main, and fix everything npm audit reports: 33 findings, 18 high, all in dev dependencies except ajv and uuid. - axios 1.x, superagent 10, mocha 12, @cucumber/cucumber 13, nyc 18 - TypeScript 5.9 with typedoc 0.28 and @types/node 22.20; uuid 11 ships type declarations that need TypeScript 5 - ajv ^8.18 and uuid ^11.1.1 at runtime; both are non-breaking, the SDK only calls uuid v4() - override fast-json-patch for ajv-cli, which has no fixed release - drop @types/uuid and @types/cucumber; both packages ship their own types - JSONParser.parse is typed as returning unknown, which is what it already returned; the class is not exported - the axios test helper serializes the object-valued extension header, since axios 1.x coerces every header value to a string - examples/typescript-ex: cloudevents ^10, gts 7 with an eslint flat config in place of tslint, TypeScript 5.9 Supersedes #612, #613, #617, #618, #619, #622, #629, #632, #633, #637, #638, #640, #642 and the dependency bumps in #645. Signed-off-by: Shiva <shiv@shiv.me>
Contributor
|
closed by #661 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
package.json
src/event/validation.ts — replaced the @ts-ignore'd reduce with a properly typed reduce. Same behavior, no suppression needed.
src/parsers.ts — added a small as string cast on the parseJSON return to keep the existing public API shape.
Verified: npm install, npm run lint, npm run build, npm test (222 passing)
Description
Bump UUID library to 11.1.1 to address GHSA-w5hq-g745-h8pq
Necessitates update to typescript 5 and cascading changes