Skip to content

Fix crashes when non-vanilla enchants are present - #56

Merged
zefir-git merged 6 commits into
mainfrom
55-error-when-registering-permission-node
Oct 22, 2026
Merged

zefir-git merged 6 commits into
mainfrom
55-error-when-registering-permission-node

Conversation

@zefir-git

@zefir-git zefir-git commented Jun 14, 2026 •

Copy link
Copy Markdown
Member

Adds new permission nodes in the form enchantbookplus.enchant.<namespace>.<enchantment> for custom enchantments.

The configuration name key now also accepts optional namespace, defaulting to minecraft:.

In other words, existing permissions and configs work for vanilla enchantments. Custom enchantments require specifying their namespace.

@zefir-git zefir-git self-assigned this Jun 14, 2026
@zefir-git zefir-git added the bug Something isn't working label Jun 14, 2026
@zefir-git zefir-git linked an issue Jun 14, 2026 that may be closed by this pull request
@zefir-git zefir-git changed the title unregister permissions on disable custom namespace enchants Jul 17, 2026
@zefir-git zefir-git changed the title custom namespace enchants Fix crashes when non-vanilla enchants are present Oct 22, 2026
@zefir-git
zefir-git marked this pull request as ready for review October 22, 2026 08:34
@zefir-git
zefir-git requested a review from a team as a code owner October 22, 2026 08:34
@zefir-git
zefir-git merged commit 88e1e17 into main Oct 22, 2026
1 check passed
@zefir-git
zefir-git deleted the 55-error-when-registering-permission-node branch October 22, 2026 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when registering permission node

1 participant