Repository navigation
fix(CF-2507): list the shell-evaluated arguments of codefresh-run and helm - #739
Open
andrii-codefresh wants to merge 5 commits into
Open
andrii-codefresh wants to merge 5 commits into
andrii-codefresh wants to merge 5 commits into
Conversation
… helm
The engine substitutes Codefresh variables into step arguments as text, and
these steps evaluate some arguments with a shell, so a branch name or a commit
message could run commands.
The arguments schemas now mark these arguments with "x-shell-evaluated"
("unquoted" or "double-quoted"). In the marked arguments the engine passes the
Git variables to the shell as environment variables. Engines without this
support ignore the keyword, so the steps work as before.
Contributor
Author
|
/e2e |
This reverts commit 49f4542.
… helm in spec.shellEvaluatedArguments Replace the x-shell-evaluated marks in the argument schemas with spec.shellEvaluatedArguments, which pipeline-manager validates. The argument schemas are the same as before. The planner passes Git variables in the listed arguments as environment variables, so the shell does not evaluate their values.
andrii-codefresh
changed the title
masontikhonov
approved these changes
Nov 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The engine substitutes Codefresh variables into step arguments as text, and these steps evaluate some arguments with a shell, so a branch name or a commit message could run commands.
The steps now list these arguments in
spec.shellEvaluatedArgumentswith where each one goes into the shell command:unquoted,double-quotedorsingle-quoted. When theshellSafeGitVariablesfeature flag is on, the planner (ShellArguments) passes the Git variables in the listed arguments to the shell as environment variables. The argument schemas are the same as before.pipeline-manager validates the new field, so release pipeline-manager before merging this PR.