Skip to content

test: drop the removed Response constructor argument in HTTP tests #10613

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
paulbalandan merged 1 commit into from
Oct 9, 2026
Merged

test: drop the removed Response constructor argument in HTTP tests #10613

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/system/HTTP/ContentSecurityPolicyTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ public function testReportOnly(): void

Services::injectMock('csp', new ContentSecurityPolicy($config));

$this->response = new Response(config(App::class));
$this->response = new Response();
$this->response->pretend(false);
$this->csp = $this->response->getCSP();

Expand Down
2 changes: 1 addition & 1 deletion tests/system/HTTP/ResponseTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -490,7 +490,7 @@ public function testGetDownloadResponseByFilePath(): void

public function testGetDownloadResponseByExtremeFilePath(): void
{
$response = new Response(new App());
$response = new Response();

$tempDir = sys_get_temp_dir() . DIRECTORY_SEPARATOR . 'ci4_test_dir_' . bin2hex(random_bytes(8));
$this->assertTrue(mkdir($tempDir));
Expand Down
12 changes: 1 addition & 11 deletions utils/phpstan-baseline/arguments.count.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# total 6 errors
# total 4 errors

parameters:
ignoreErrors:
Expand All @@ -11,13 +11,3 @@ parameters:
message: '#^Function is_cli invoked with 1 parameter, 0 required\.$#'
count: 2
path: ../../tests/system/Debug/ToolbarTest.php

-
message: '#^Class CodeIgniter\\HTTP\\Response constructor invoked with 1 parameter, 0 required\.$#'
count: 1
path: ../../tests/system/HTTP/ContentSecurityPolicyTest.php

-
message: '#^Class CodeIgniter\\HTTP\\Response constructor invoked with 1 parameter, 0 required\.$#'
count: 1
path: ../../tests/system/HTTP/ResponseTest.php
2 changes: 1 addition & 1 deletion utils/phpstan-baseline/loader.neon
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
# total 32 errors
# total 30 errors

includes:
- arguments.count.neon
Expand Down
Loading