Repository navigation
Conversation
carson-codeigniter4
Bot
added
the
bug
michalsn
reviewed
Oct 18, 2026
michalsn
left a comment
michalsn
left a comment
Member
There was a problem hiding this comment.
Could we keep setDefaultSrc() replacing the current source list and use addDefaultSrc() to append sources? The existing test explicitly verifies replacement, so changing the setter to append would break existing behavior.
gr8man
force-pushed
the
fix/csp-set-default-src
branch
from
October 18, 2026 22:04
5f6b810 to
9f759b5
Compare
paulbalandan
changed the title
ContentSecurityPolicy::setDefaultSrc() add directives instead of overwriting
This comment has been minimized.
This comment has been minimized.
paulbalandan
left a comment
paulbalandan
left a comment
Member
There was a problem hiding this comment.
The PR title and body still describes the stale behavior. Please update both.
… add addDefaultSrc()
gr8man
changed the title
ContentSecurityPolicy::setDefaultSrc() add directives instead of overwriting
gr8man
force-pushed
the
fix/csp-set-default-src
branch
from
October 23, 2026 19:22
9f759b5 to
67da259
Compare
paulbalandan
approved these changes
Oct 24, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes
ContentSecurityPolicy::setDefaultSrc()when passed an array of URIs, which previously resulted in an invalid'Array'directive. Also addsaddDefaultSrc()to allow appending sources to thedefault-srcdirective for consistency with other CSP directive methods.Checklist: