Repository navigation
fix: widen accepted values in set_value()'s $default - #10641
Open
paulbalandan wants to merge 2 commits into
Open
paulbalandan wants to merge 2 commits into
paulbalandan wants to merge 2 commits into
Conversation
carson-codeigniter4
Bot
added
the
bug
paulbalandan
force-pushed
the
set-value-non-string-default
branch
from
October 19, 2026 05:49
240ed59 to
6f77131
Compare
samsonasik
approved these changes
Oct 19, 2026
michalsn
approved these changes
Oct 19, 2026
neznaika0
reviewed
Oct 19, 2026
neznaika0
left a comment
neznaika0
left a comment
Contributor
There was a problem hiding this comment.
Is there any point in checking the array for valid values? I think it’s an unnecessary burden. But the topic starter on the forum mentions this.
Contributor
|
Is it worth adding a note in changelog about strict types in #10521 ? Previously, this was not approved as BC and was pushed to the next branch. |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Ref: https://forum.codeigniter.com/showthread.php?tid=94539
Checklist: