Repository navigation
fix(text-editor): keep host blocks mounted and spaced in the renderer - #213
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while testing block-based lessons in a CourseLit app.
What was wrong
ContentRendererpasses our node mappings to Tiptap's React renderer, which mounts each mapping as a component (React.createElement(mapping)). Our mappings — and Tiptap's owndocmapping — are new functions on every render, so each time the host page re-rendered, React unmounted and remounted the whole tree. In CourseLit, a learner passed a quiz, the page re-rendered, and the quiz lost its result and answers; a playing video would reload the same way.margin: 1rem 0fromprose.css; blocks rendered by the host (blocksprop) got none, so two in a row (callout → video → quiz) touched.Fix
ContentRenderernow renders throughrenderToElementwith a renderer that calls each mapping as a plain function and keys the result by position, so the element tree only holds stable types (p,figure, the host's block components). Nothing changes for server rendering: the renderer stays hook-free.<div class="te-host-block" data-block="…">, spaced like library blocks (margins collapse with paragraphs).smallButtonisshrink-0 whitespace-nowrap.Testing
vitest: 217 passed.tsc --noEmitclean, package build OK.main's renderer and this branch's under the docs profile — 0 differences.