Repository navigation
Document the browser skips of the backend sign-in tests (unbreaks website deploy) - #5969
Merged
Merged
Conversation
#5961 added four backend sign-in tests that skip in the browser by design (credentials, redirects and cookies belong to the browser there). The javascript report now carries those skips, and nothing explained them. The website build syncs the persisted reports into the checked-in snapshot one port at a time. Once the javascript report was copied in, every later port's accept run validated the contract against it, hit "Skipped tests without errata", and was labelled unusable -- so linux, windows, watchos and tvos were blamed and every master website deploy since 14:48 UTC failed. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
shai-almog
marked this pull request as ready for review
October 8, 2026 19:30
Collaborator
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Hooray! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every master website deploy since 2026-10-08 14:48 UTC fails in Build website with "6 persisted report(s) are unusable".
Cause. #5961 added
BackendAuthTest,BackendDeviceGrantTest,BackendTokenRefreshTestandBackendTotpTest, which skip on the browser port by design (credentials-redirects-and-cookies-belong-to-the-browser). The javascript report onport-status-datanow carries those skips with no erratum.sync_port_status_reports.shcopies each accepted report into the checked-in snapshot as it goes, so every port processed after javascript validated against it, failed on "Skipped tests without errata", and was reported as unusable (linux, windows, watchos, tvos). None of those reports is actually broken.Fix. Add the four skip errata, scoped to the
javascriptport.Verified locally
sync_port_status_reports.shagainst the liveport-status-data(7f10a25): before, 6 unusable and exit 1; after, 7 resolved, 4 waiting for a current-contract run, exit 0.port_status.py validate: exit 0.test_port_statusandtest_publish_port_status: 96 tests OK.🤖 Generated with Claude Code