Repository navigation
Fix MigrationEngine PMD null-check false positives - #5973
Conversation
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Developer Guide build artifacts are available for download from this workflow run:
Developer Guide quality checks: |
Cloudflare Preview
|
PMD 6.55.0 reports two
BrokenNullCheckfalse positives in the versioned/repeatable migration filters. Extract the null comparisons into named booleans so the filters retain their selection behavior and pass PMD without suppressing the rule.Validation on the fix before updating the branch to current master:
clean verifypassed: 7,697 tests, including all 32MigrationEngineTesttests; zero failures, errors, or skips.git diff --checkpassed.Command:
mvn -B -ntp -f maven/pom.xml clean verify -DunitTests=true -pl core-unittests -am -Dmaven.javadoc.skip=true -Plocal-dev-javase -Djava.awt.headless=true. Maven reported that the requestedlocal-dev-javaseprofile is absent in this checkout; the build completed successfully with Java 8.