Skip to content

Fix MigrationEngine PMD null-check false positives - #5973

Merged
shai-almog merged 1 commit into
masterfrom
fix/migration-pmd-null-checks
Oct 9, 2026
Merged

shai-almog merged 1 commit into
masterfrom
fix/migration-pmd-null-checks

Conversation

@shai-almog

Copy link
Copy Markdown
Collaborator

PMD 6.55.0 reports two BrokenNullCheck false positives in the versioned/repeatable migration filters. Extract the null comparisons into named booleans so the filters retain their selection behavior and pass PMD without suppressing the rule.

Validation on the fix before updating the branch to current master:

  • Reproduced both warnings with PMD 6.55.0 before the change.
  • Java 8 core clean verify passed: 7,697 tests, including all 32 MigrationEngineTest tests; zero failures, errors, or skips.
  • Generated PMD, SpotBugs, and Checkstyle reports contain zero active findings.
  • git diff --check passed.

Command: mvn -B -ntp -f maven/pom.xml clean verify -DunitTests=true -pl core-unittests -am -Dmaven.javadoc.skip=true -Plocal-dev-javase -Djava.awt.headless=true. Maven reported that the requested local-dev-javase profile is absent in this checkout; the build completed successfully with Java 8.

@shai-almog

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

Reviewed commit: 021767e226

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-09T11:39:40.606187Z 021767e Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Developer Guide build artifacts are available for download from this workflow run:

Developer Guide quality checks:

  • AsciiDoc linter: No issues found (report)
  • Vale: No alerts found (report)
  • Paragraph capitalization: No paragraph capitalization issues (report)
  • LanguageTool: No grammar matches (report)
  • Image references: No unused images detected (report)

@github-actions

github-actions Bot commented Oct 9, 2026

Copy link
Copy Markdown
Contributor

Cloudflare Preview

@shai-almog
shai-almog merged commit d65703a into master Oct 9, 2026
@shai-almog
shai-almog deleted the fix/migration-pmd-null-checks branch October 9, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant