Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ARM64 installs never see updates.
Update-AppCast.ps1writes a single appcast item with both the x64 and arm64 enclosures, but NetSparkle reads only the first enclosure of each item (XMLAppCastGenerator.cs). So every item parses aswin-x64, and our OS filter drops it on ARM64.This change has the script write one item per architecture, each with a single enclosure. All existing items for the channel are replaced, so re-running stays idempotent. Existing clients pick up the fix without updating, since only the appcast changes.
The live appcast will be fixed by the next release that runs this script. Until then, ARM64 users on 0.8.4 won't see 0.8.5.
Verification
I ran the script under pwsh 7.4 on Linux with stubbed
gh.exeandopenssl.exe, starting from the live appcast. Then I ran it again on its own output. I parsed each file with NetSparkle 3.0.3'sXMLAppCastGeneratorand applied the app's channel, OS, and version filter for an installed 0.8.4:The output has 2 items after each run.
Generated by Coder Agents.