Repository navigation
Fix macos-verify.sh for relative paths - #260
Merged
Merged
Conversation
The certificate was extracted after a cd into a temp folder, so relative paths (as the release workflow passes them) were not found and the check exited without a message. Extract with a path prefix instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The v0.2.31 release run signed and notarized the macOS binaries and apps fine, but
scripts/macos-verify.shthen exited silently: it extracted the signing certificate after acdinto a temp folder, so the relative paths the workflow passes were not found (my local tests used absolute paths).Now the certificate is extracted with
--extract-certificates=<prefix>without changing directory, and a missing certificate gives a clear error.Tested with relative paths (a signed binary, the v0.2.30 DMG and update bundle, and
rel dir/Godmode Bot.appwith spaces): all pass.