Skip to content

feat(sync-actions): support setSavedToLineItem for product type attribute definitions - #1983

Merged
markus-azer merged 2 commits into
masterfrom
feat/product-type-set-saved-to-line-item
Oct 22, 2026
Merged

markus-azer merged 2 commits into
masterfrom
feat/product-type-set-saved-to-line-item

Conversation

@markus-azer

Copy link
Copy Markdown
Member

Summary

Description

  • Adds savedToLineItem to the attribute-definition field map.
  • Adds tests for true, false and undefined transitions.
  • Adds a minor changeset.

Todo

  • Tests
    • Unit
    • Integration
    • Acceptance
  • Documentation
  • Type label for the PR

@changeset-bot

changeset-bot Bot commented Oct 22, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: bd69738

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@commercetools/sync-actions Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented Oct 22, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.48%. Comparing base (a6d6e2b) to head (bd69738).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1983   +/-   ##
=======================================
  Coverage   98.48%   98.48%           
=======================================
  Files         117      117           
  Lines        3032     3032           
  Branches      854      854           
=======================================
  Hits         2986     2986           
  Misses         42       42           
  Partials        4        4           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrowly scoped mapping follows the existing generation pattern, relevant transitions have test coverage, and static review identified no blocking issues.

No open issues 🎉

What changed in this PR

Adds support for generating setSavedToLineItem update actions for product type attribute definitions in @commercetools/sync-actions.

Changes:

  • Adds savedToLineItem to the attribute-definition action map.
  • Adds tests for boolean and undefined transitions and updates the action snapshot.
  • Includes a minor-release changeset.
File Description
packages/​sync-actions/​test/​product-types-sync-attribute-hints.spec.js Tests action generation for savedToLineItem changes.
packages/​sync-actions/​test/​__snapshots__/​product-types-sync-attribute-hints.spec.js.snap Includes the new action in the expected output.
packages/​sync-actions/​src/​product-types-actions.js Maps savedToLineItem changes to setSavedToLineItem.
.changeset/​quick-lines-save.md Documents the feature for a minor release.

Review effort: Balanced

@markus-azer
markus-azer merged commit 7e07c2f into master Oct 22, 2026
13 checks passed
@markus-azer
markus-azer deleted the feat/product-type-set-saved-to-line-item branch October 22, 2026 12:10
@ct-changesets ct-changesets Bot mentioned this pull request Oct 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants