Repository navigation
Backport IMAP and POP3 command validation to Python 3.12 - #972
Closed
saakshaat-singh wants to merge 2 commits into
Closed
saakshaat-singh wants to merge 2 commits into
saakshaat-singh wants to merge 2 commits into
Conversation
Contributor
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipe/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/43941459712. Examine the logs at this URL for more detail. |
saakshaat-singh
force-pushed
the
ssingh/312-security-backports
branch
from
November 16, 2026 19:13
c1351cf to
2bb8836
Compare
saakshaat-singh
force-pushed
the
ssingh/312-security-backports
branch
from
November 16, 2026 19:28
2bb8836 to
d9cf7bf
Compare
saakshaat-singh
marked this pull request as ready for review
November 16, 2026 19:52
saakshaat-singh
requested review from
chrisburr,
isuruf,
jakirkham,
katietz,
mbargull,
msarahan,
ocefpaf,
pelson,
scopatz and
xhochy
as code owners
November 16, 2026 19:52
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before this PR
The Python 3.12.16 package accepts command-injection characters in
imaplibandpoplib, leaving CVE-2025-15366 and CVE-2025-15367 unresolved on this branch.After this PR
==COMMIT_MSG==
==COMMIT_MSG==
This adds the upstream mail-command validation patches to the Python 3.12.16 recipe and increments the build number for a rebuilt package. Installed-package regression checks verify rejection before transmission, preservation of valid commands, and cleanup of a rejected IMAP message literal.
Upstream context
The corresponding 3.12 source proposals are python/cpython#162135 and python/cpython#162136. Upstream previously withheld mail backports over compatibility concerns, and the APPEND cleanup is still under review. This package proposal therefore requires an explicit decision about carrying these downstream patches; upstream acceptance is not assumed.
Related PR #969 carries mail backports for Python 3.9 and does not supply a 3.12 package. The separate Base64 proposal #973 is not required for these mail changes.
Validation
The complete 25-patch series applies to a clean v3.12.16 checkout and reproduces the tested source tree. The original 23 packaging patches are preserved. The IMAP and POP3 source suites completed 184 tests with 6 skipped using the released conda-forge Python 3.12.16 interpreter; all three installed-package regression checks passed against the patched sources. The recipe passes
conda-smithy recipe-lint. Full package builds remain for feedstock CI.Review and next steps
Testing
Possible downsides?
POP3 credentials containing control characters will now be rejected. The package would carry changes that CPython has not accepted for 3.12, including a pending IMAP follow-up, and therefore assumes responsibility for that downstream compatibility choice.
Are Docs needed?