Skip to content

Fix: replace hardcoded credentials in tests (Snyk) - #274

Open
reeshika-h wants to merge 1 commit into
developmentfrom
fix/snyk-java-deps-and-credentials
Open

reeshika-h wants to merge 1 commit into
developmentfrom
fix/snyk-java-deps-and-credentials

Conversation

@reeshika-h

Copy link
Copy Markdown
Contributor

Summary

Resolves DX-22133 and DX-22134 (hardcoded credentials / security-relevant constants in tests). Test-only; no version bump.

  • LoginDetailTest: username is a generated value (the assert uses the same variable).
  • TestClient: the API-key fallback is generated at runtime instead of a literal. Removed the deepcode ignore comments.

Verification

  • snyk code test: 2 → 0; snyk test: 0.
  • Tests: 223 run, 50 errors, identical to the baseline before this change (environment/network failures; pom.xml ships skipTests=true).

🤖 Generated with Claude Code

Generated username and API-key fallback in tests; remove deepcode ignore comments.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
@reeshika-h
reeshika-h requested a review from a team as a code owner October 26, 2026 10:55
@snyk-io

snyk-io Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

✅ Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
✅ Open Source Security 0 0 0 0 0 issues
✅ Licenses 0 0 0 0 0 issues
✅ Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions

Copy link
Copy Markdown

🔒 Security Scan Results

ℹ️ Note: Only vulnerabilities with available fixes (upgrades or patches) are counted toward thresholds.

Check Type Count (with fixes) Without fixes Threshold Result
🔴 Critical Severity 0 0 10 ✅ Passed
🟠 High Severity 0 0 25 ✅ Passed
🟡 Medium Severity 0 0 500 ✅ Passed
🔵 Low Severity 0 0 1000 ✅ Passed

⏱️ SLA Breach Summary

✅ No SLA breaches detected. All vulnerabilities are within acceptable time thresholds.

Severity Breaches (with fixes) Breaches (no fixes) SLA Threshold (with/no fixes) Status
🔴 Critical 0 0 15 / 30 days ✅ Passed
🟠 High 0 0 30 / 120 days ✅ Passed
🟡 Medium 0 0 90 / 365 days ✅ Passed
🔵 Low 0 0 180 / 365 days ✅ Passed

✅ BUILD PASSED - All security checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant