Skip to content

test: cover response-size limiter context propagation #7879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 1 commit into
base: master
Choose a base branch
from
Open

test: cover response-size limiter context propagation #7879

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
43 changes: 43 additions & 0 deletions pkg/util/limiter/response_size_limiter_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package limiter

import (
"context"
"testing"

"github.com/stretchr/testify/require"
Expand All @@ -17,3 +18,45 @@ func TestResponseSizeLimiter_AddDataBytes(t *testing.T) {
require.Error(t, err)
require.Contains(t, err.Error(), "the query response size exceeds limit")
}

func TestResponseSizeLimiterFromContextWithFallback(t *testing.T) {
t.Run("missing limiter allows unlimited response bytes", func(t *testing.T) {
limiter := ResponseSizeLimiterFromContextWithFallback(context.Background())
require.NotNil(t, limiter)

require.NoError(t, limiter.AddResponseBytes(4096))
require.NoError(t, limiter.AddResponseBytes(4096))
})

t.Run("child contexts share the query response budget", func(t *testing.T) {
limiter := NewResponseSizeLimiter(4096)
ctx := AddResponseSizeLimiterToContext(context.Background(), limiter)
firstCtx, cancelFirst := context.WithCancel(ctx)
defer cancelFirst()
secondCtx, cancelSecond := context.WithCancel(ctx)
defer cancelSecond()

first := ResponseSizeLimiterFromContextWithFallback(firstCtx)
second := ResponseSizeLimiterFromContextWithFallback(secondCtx)
require.Same(t, limiter, first)
require.Same(t, limiter, second)

require.NoError(t, first.AddResponseBytes(2048))
require.NoError(t, second.AddResponseBytes(2048))
require.EqualError(t, first.AddResponseBytes(1), "the query response size exceeds limit (limit: 4096 bytes)")
require.EqualError(t, second.AddResponseBytes(1), "the query response size exceeds limit (limit: 4096 bytes)")
})

t.Run("separate queries have independent response budgets", func(t *testing.T) {
parent := context.Background()
firstCtx := AddResponseSizeLimiterToContext(parent, NewResponseSizeLimiter(4096))
secondCtx := AddResponseSizeLimiterToContext(parent, NewResponseSizeLimiter(4096))
first := ResponseSizeLimiterFromContextWithFallback(firstCtx)
second := ResponseSizeLimiterFromContextWithFallback(secondCtx)

require.NoError(t, first.AddResponseBytes(4096))
require.EqualError(t, first.AddResponseBytes(1), "the query response size exceeds limit (limit: 4096 bytes)")
require.NoError(t, second.AddResponseBytes(4096))
require.NoError(t, ResponseSizeLimiterFromContextWithFallback(parent).AddResponseBytes(8192))
})
}