Repository navigation
docs: pin the clang tool version only in additional_dependencies - #308
Conversation
Giving the version in both --version and additional_dependencies wrote it twice. Without --version the hook uses the installed wheel, so the examples now pin it in additional_dependencies only and describe --version as the alternative.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #308 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 541 541
=========================================
Hits 541 541 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
WalkthroughThe documentation now describes ChangesTool version pinning documentation
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~8 minutes Merge Risk: ⚪ Minimal · up to
|



#307 showed
--version=21andadditional_dependencies: [clang-format==21.1.8]together, so the version was written twice. Without--version, the hook uses the wheel that is installed in its environment (since #302), so one place is enough.additional_dependencies, like mirrors-clang-format pins it only inrev.--versionas the alternative: the hook picks and installs the wheel the first time it runs.--versionwins and installs at run time).--version, since they showfiles,--jobsand--verbose.Checked with pre-commit: a hook with only
additional_dependencies: [clang-format==20.1.8]prints "Using installed clang-format Python wheel version 20.1.8" and installs nothing at run time.Summary by CodeRabbit
--versionoption.--versiontakes precedence if pinning methods conflict and may require network access.