Skip to content

fix: Respect gen_patch when caching clang-format output - #512

Merged
2bndy5 merged 2 commits into
add-fix-argfrom
copilot/fix-failing-github-actions-job
Oct 20, 2026
Merged

2bndy5 merged 2 commits into
add-fix-argfrom
copilot/fix-failing-github-actions-job

Conversation

Copilot AI commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

With patch generation disabled, clang-format still wrote a cached patched file and set patched_path, contradicting the expected behavior. Gate cache creation on gen_patch while continuing to collect format advice.

  • Behavior: gen_patch = false leaves patched_path unset; format advice remains available.
  • Implementation: Cache clang-format output only when patch generation is enabled.
if clang_params.gen_patch {
    // write formatted output to cache and set patched_path
}

Co-authored-by: 2bndy5 <14963867+2bndy5@users.noreply.github.com>
@2bndy5
2bndy5 added this pull request to stack #513 October 20, 2026 17:26
@2bndy5 2bndy5 changed the title Respect gen_patch when caching clang-format output fix: Respect gen_patch when caching clang-format output Oct 20, 2026
@codecov

codecov Bot commented Oct 20, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.15%. Comparing base (fedeef8) to head (274e9a8).
⚠️ Report is 1 commits behind head on add-fix-arg.

Additional details and impacted files
@@               Coverage Diff               @@
##           add-fix-arg     #512      +/-   ##
===============================================
+ Coverage        96.64%   99.15%   +2.51%     
===============================================
  Files               26       28       +2     
  Lines             5903     6753     +850     
===============================================
+ Hits              5705     6696     +991     
+ Misses             198       57     -141     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@2bndy5
2bndy5 marked this pull request as ready for review October 20, 2026 22:39
`clang_params.gen_patch ` needed to be `true` but is `false` by default
@2bndy5
2bndy5 removed this pull request from stack #513 October 20, 2026 23:36
@2bndy5
2bndy5 merged commit c0f9dd1 into add-fix-arg Oct 20, 2026
72 of 73 checks passed
@2bndy5
2bndy5 deleted the copilot/fix-failing-github-actions-job branch October 20, 2026 23:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants