Repository navigation
fix: Respect gen_patch when caching clang-format output - #512
Merged
Merged
Conversation
Co-authored-by: 2bndy5 <14963867+2bndy5@users.noreply.github.com>
2bndy5
added this pull request to stack #513
October 20, 2026 17:26
gen_patch when caching clang-format outputgen_patch when caching clang-format output
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## add-fix-arg #512 +/- ##
===============================================
+ Coverage 96.64% 99.15% +2.51%
===============================================
Files 26 28 +2
Lines 5903 6753 +850
===============================================
+ Hits 5705 6696 +991
+ Misses 198 57 -141 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
2bndy5
marked this pull request as ready for review
October 20, 2026 22:39
`clang_params.gen_patch ` needed to be `true` but is `false` by default
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With patch generation disabled, clang-format still wrote a cached patched file and set
patched_path, contradicting the expected behavior. Gate cache creation ongen_patchwhile continuing to collect format advice.gen_patch = falseleavespatched_pathunset; format advice remains available.