Skip to content

Add test for #8789 - #9022

Merged
chrchr-github merged 1 commit into
cppcheck-opensource:mainfrom
chrchr-github:chr_8789
Nov 13, 2026
Merged

chrchr-github merged 1 commit into
cppcheck-opensource:mainfrom
chrchr-github:chr_8789

Conversation

@chrchr-github

Copy link
Copy Markdown
Collaborator

No description provided.

@dmcppcheck dmcppcheck left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review

I found no problems. The PR only adds a regression test for #8789 to TestTokenizer::simplifyNamespaceStd. The test checks that, after using namespace std;, a call to search with 3 arguments is left unqualified, while a call with 4 arguments becomes std::search. That matches the 4-argument std::search entry in cfg/std.cfg and what the cppcheck binary does now.

Testing

  • Built cppcheck and testrunner in pr/ with make -j8.
  • ./testrunner TestTokenizer ran 392 tests: 0 failed, 3 todos.
  • I ran the PR's binary on the code from the test with cppcheck --debug-normal a.cpp. The output matches what the test expects:
    3: search ( p , q , p ) ;
    4: std :: search ( p , q , p , q ) ;
    
  • I did not build base/ or run it, because the PR changes no library code.

Automated review of bcab7ac by Claude. The pull request was built and tested locally.

@chrchr-github
chrchr-github merged commit 21da1f0 into cppcheck-opensource:main Nov 13, 2026
71 checks passed
@chrchr-github
chrchr-github deleted the chr_8789 branch November 13, 2026 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants